Add aarch64-linux bindist CI job and mirroring logic #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerrorJack
force-pushed
the
aarch64-linux-bindist
branch
from
7079dbd
to
0ae6dd8
Compare
amesgen
approved these changes
May 20, 2024
| (,) | ||
| "wasm32-wasi-ghc-gmp-aarch64-linux" | ||
| BindistInfo | ||
| { isGhcBindist = False, |
There was a problem hiding this comment.
Only noticing this now: We currently can't set this to True for the GHA-built bindists for at least two reasons:
- The GHA bindists use zstd instead of lzma, and the current ghc subdir logic only supports lzma (should be easy to fix).
- GHA artifacts are wrapped in another
.ziplayer, so that would also have to be removed.
However, fixing this isn't a big priority; this mechanism was added in #6 mostly as convenient metadata for downstream consumers like ghcup.
There was a problem hiding this comment.
That's right. We should definitely remove the zip layer, though I believe this is better suited for a follow-up PR. As for zstd, it's largely my personal preference, we can also fix subdir logic for it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #15. The custom runner
makimais a ubi8 container on my personal server.It's a pity github runner doesn't officially support alpine yet (see actions/runner#801). I'm not interested in the workarounds out there, so might as well build our aarch64-linux bindists in a distro with reasonably old glibc and will still be actively supported for a while.