Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: add aria-label to SVG with tooltip #40808

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Docs: add aria-label to SVG with tooltip #40808

wants to merge 2 commits into from
+1 −1

Conversation

hannahiss
Copy link
Contributor

Description

Motivation & Context

The is no label/accessible name for the SVG which has a toolitp.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@hannahiss hannahiss marked this pull request as ready for review September 10, 2024 13:52
@hannahiss hannahiss mentioned this pull request Sep 10, 2024
Open
10 tasks
hannahiss added a commit to Orange-OpenSource/Orange-Boosted-Bootstrap that referenced this pull request Sep 10, 2024
@hannahiss
Rollback change of aria-label on SVG tooltip, since it will come back…
d2295d2 
… from Bootstrap PR twbs/bootstrap#40808
@hannahiss hannahiss mentioned this pull request Sep 10, 2024
Merged
julien-deramond
julien-deramond approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and to @patrickhlauke (see #40756 (comment) thread)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
accessibility v5
Projects
v5.3.4
Status: Ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahiss @julien-deramond