Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix popover template role error #38978

Merged
merged 1 commit into from
Jul 29, 2023
Merged

Docs: Fix popover template role error #38978

merged 1 commit into from
Jul 29, 2023

Conversation

coliff
Copy link
Contributor

@coliff coliff commented Jul 28, 2023

Description

I'm quite sure this should be role="tooltip" and not role="popover". There isn't a popover role but there is a tooltip one.(https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role).. and Bootstrap 5 itself uses role="tooltip" for its popovers by default.

Motivation & Context

Fixing a bug

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

I'm quite sure this should be `role="tooltip"` and not `role="popover"`.  There isn't a popover role but there is a tooltip one.(https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role).. and Bootstrap 5 itself uses role="tooltip" for its popovers by default.
Copy link
Member

@patrickhlauke patrickhlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted

@patrickhlauke patrickhlauke merged commit 92aedd1 into twbs:main Jul 29, 2023
13 checks passed
@coliff coliff deleted the patch-3 branch July 29, 2023 23:50
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
I'm quite sure this should be `role="tooltip"` and not `role="popover"`.  There isn't a popover role but there is a tooltip one.(https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tooltip_role).. and Bootstrap 5 itself uses role="tooltip" for its popovers by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants