Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bottom border on dark navbar example #38707

Merged
merged 3 commits into from
Jun 25, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jun 5, 2023

Description

As mentioned in #38706, .border-bottom-dark doesn't exist in Bootstrap.

Moreover, adding a border is finally probably a bit useless here since it adds some noise to the understanding of the concept explained in this section. Rather than fixing it, IMO, it's better to completely remove the border and focus only on the color scheme concept.

However, if you have a strong opinion on its presence and that it's still useful to see the limit of the navbar in dark mode, we could use in this case .border-body instead of .border-dark.

Motivation & Context

A better understanding of the feature without noise.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #38706

@julien-deramond julien-deramond marked this pull request as ready for review June 5, 2023 11:32
@julien-deramond julien-deramond changed the title Docs: drop bottom border from dark nabvar example Docs: drop bottom border from dark navbar example Jun 5, 2023
@julien-deramond julien-deramond force-pushed the main-jd-drop-border-bottom-from-navbar-color-schemes branch from 7434d8e to 9c15cee Compare June 5, 2023 11:42
@julien-deramond
Copy link
Member Author

Based on #38706 (comment), reintroduced the bottom border associated to .border-body for its color (0b2df3b).

@mdo mdo changed the title Docs: drop bottom border from dark navbar example Update bottom border on dark navbar example Jun 25, 2023
@mdo mdo merged commit 6dc18c6 into main Jun 25, 2023
@mdo mdo deleted the main-jd-drop-border-bottom-from-navbar-color-schemes branch June 25, 2023 21:46
romankupchak93 pushed a commit to romankupchak93/bootstrap that referenced this pull request Jan 5, 2024
* Docs: drop bottom border from dark navbar example

* Use `.border-body`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Documentation of navbar, Color schemes: border-bottom
2 participants