Add data attr selector for dark mode navbars #38522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
TBH I don't see another way of tackling it for now.
However, when I try your change locally with $color-mode-type set to media-query, I can see a weird rendering in light mode of the first example in /docs/5.3/components/navbar/#color-schemes because of .bg-body-secondary (the background color is too light).
Moreover, we have
And then, the corresponding markup is shown right-after is with
.bg-dark 🤔
10 tasks
romankupchak93
pushed a commit
to romankupchak93/bootstrap
that referenced
this pull request
Jan 5, 2024
* Add data attr selector for dark mode navbars * Fix dark example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38363, I think. We advise folks to use the
data-bs-themeselectors for toggling dark mode on some components, but when using themedia-querytype for color modes, the selectors aren't available. So we need to include something like this branch proposes./cc @julien-deramond for ideas on if there's a better approach here.