Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: Horizontal collapse #36434

Merged
merged 1 commit into from
Jun 2, 2022
Merged

v4: Horizontal collapse #36434

merged 1 commit into from
Jun 2, 2022

Conversation

mdo
Copy link
Member

@mdo mdo commented May 24, 2022

Backports #34253 to v4. Changes the collapse-horizontal to width for those who've secretly been using this feature for years in Bootstrap 4 but never saw official support.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌

IDK if anything must be done in the v5 migration guide. At the moment we have:

Collapse plugin now supports horizontal collapsing. — Add .collapse-horizontal to your .collapse to collapse the width instead of the height. Avoid browser repainting by setting a min-height or height.

Depending from which version you start and to which version you go you have several scenarios.

  • v4 (<v4.7.0) → v5 (>=v5.1.0): Collapse plugin now supports horizontal collapsing
  • v4.7.0 → v5.0.0: Collapse plugin doesn't exist anymore
  • v4.7.0 → v5 (>=v5.1.0): .width must be changed to .collapse-horizontal

@mdo mdo merged commit 4444f09 into v4-dev Jun 2, 2022
@mdo mdo deleted the v4-collapse-horizontal branch June 2, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants