Hound: Disable scss. #24221
Merged
Hound: Disable scss. #24221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johann-S
approved these changes
Oct 3, 2017
XhmikosR
force-pushed
the
v4-dev-hound-disable-scss
branch
6 times, most recently
from
4161e28
to
75bbd9d
Compare
|
How trivial is it to setup stylelint to report back via CI instead of code review like Hound? |
|
Are you able to clarify what you're trying to achieve here? You're spawning three separate Node 8 containers, two of which seem to do the same thing. (Or are you still fiddling with this PR?) |
|
@mdo we're already doing that. Hound as an additional layer of linting is just being mad, presumably for the reason mentioned in #23572 (comment), and XhmikosR additionally says in #24225 that there may be some bugs in Hound's stylelint implementation. |
|
From what I understand, Hound is using their own configs which is why this doesn't work properly. @bardiharborow: this PR is just for testing crap until merge time. |
XhmikosR
force-pushed
the
v4-dev-hound-disable-scss
branch
from
75bbd9d
to
6b07665
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #24225