Remove color property from badge class
#23529
Merged
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest removing `color: #FFF` from the `badge` class, because it is provided by the `badge-<modifier>` classes along with a background-color, whereas there is no corresponding background-color provided on the `badge` class itself. Background ---------- According to the documentation: > [badge] Requires one of the contextual, color modifier classes for `color` and > `background-color`. That is, color and background color should be provided by a modifier class, rather than the badge class itself. e.g. `<span class='badge badge-primary'>4</span>` In general, providing a `color` property without also providing a `background-color` should be avoided. [W3 QA tips] In this context, this is a problem only if someone creates a `badge` without providing a modifier. Such an omition may be difficult to trouble-shoot, because this will most likely yield white text on a white background. [W3 QA tips](https://www.w3.org/QA/Tips/color)
jonwolski
force-pushed
the
fix/badge-default-colors
branch
from
66f3837
to
f07d870
Compare
|
Should |
|
Addressed in 26e6d8b and merged. Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest removing
color: #FFFfrom thebadgeclass, because it isprovided by the
badge-<modifier>classes along with abackground-color, whereas there is no corresponding background-color
provided on the
badgeclass itself.Background
According to the documentation:
That is, color and background color should be provided by a modifier
class, rather than the badge class itself.
For example:
rather than
In general, providing a
colorproperty without also providing abackground-colorshould be avoided. [W3 QA tips]In this context, this is a problem only if someone creates a
badgewithout providing a modifier. Such an omition may be difficult to trouble-shoot,
because this will most likely yield white text on a white background.
W3 QA tips