Update Popper.js to 1.11.0 #23162
Merged
Update Popper.js to 1.11.0 #23162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
reviewed
Jul 27, 2017
| @@ -3267,9 +3267,9 @@ | |||
| "dev": true | |||
| }, | |||
| "popper.js": { | |||
| "version": "1.10.8", | |||
There was a problem hiding this comment.
Are you sure there are no other deps due to the popper.js update?
There was a problem hiding this comment.
Popper.js has no deps so it shouldn't have other deps
There was a problem hiding this comment.
Right. Looks good to me then. 👍
XhmikosR
approved these changes
Jul 27, 2017
bardiharborow
approved these changes
Jul 27, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Popper.js to have those awesome bugfixes : https://github.com/FezVrasta/popper.js/releases/tag/v1.11.0
IMO this PR should be merged before our first beta @mdo
and I removed the line which add an error because we don't have Popper's
.js.mapfile @XhmikosR 😉