Drop offsets and push/pull for new order variants #22942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 30, 2017
scss/mixins/_grid-framework.scss
Outdated
| } | ||
| @for $i from 1 through $columns { | ||
| .order#{$infix}-#{$i} { | ||
| order: $i |
There was a problem hiding this comment.
Declaration should be terminated by a semicolon
houndci-bot
reviewed
Jun 30, 2017
scss/mixins/_grid-framework.scss
Outdated
| } | ||
| @for $i from 1 through $columns { | ||
| .order#{$infix}-#{$i} { | ||
| order: $i |
There was a problem hiding this comment.
Declaration should be terminated by a semicolon
Closed
alanorth
added a commit
to alanorth/hugo-theme-bootstrap4-blog
that referenced
this pull request
Aug 13, 2017
Bootstrap 4.0 Beta 1 dropped the offset classes in favor of margin classes. We need to use `ml-auto` instead of `offset-sm-1` here to get the same effect. See: twbs/bootstrap#22942 See: twbs/bootstrap#23388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops a few grid classes and replaces most of their functionality with a new set of classes. Instead of
.push-/.pull, we have.order-{1-12}and.offset-s have been removed. The former are made duplicate by theorderclasses when combined with our move to flexbox, so we save some file size there. The latter can be largely replaced with margin utilities like.mr-autoand.ml-auto, as the new docs here show.