Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs and CSS updates for #21807 #22336

Merged
merged 7 commits into from
Apr 8, 2017
Merged

Docs and CSS updates for #21807 #22336

merged 7 commits into from
Apr 8, 2017

Conversation

mdo
Copy link
Member

@mdo mdo commented Apr 2, 2017

#21807 merged without a thorough review of the new docs content, and without some changes to the CSS reverted or changed. This PR aims to take care of those things.

This removes the CSS that was added for the justified and fill variants; that was tackled by requiring .nav-item on .nav-link in caebfcd. This way, we're not setting CSS just to override it in the following ruleset.

The docs updates are relatively straightforward. Some grammar fixes and minor tweaks here and there mostly. The biggest change was redoing the scrollspy's docs intro; I hate seeing huge callouts. Instead of that, let's just lead with "here's what you need."

Might keep pushing some tweaks here, unsure yet if this is ready to go. Still reading all the docs changes from that PR.

/cc @vanduynslagerp @Johann-S

@mdo mdo added this to the v4.0.0-beta milestone Apr 2, 2017
@pvdlg
Copy link
Contributor

pvdlg commented Apr 2, 2017

Docs changes looks good to me. English is not my mother tongue, so there is surely improvement possible in the doc I wrote :-)

Regarding the CSS, as mentioned in this comment the change here create an issue with the bottom border of active tabs with this markup:

<nav class="nav nav-tabs">
    <a class="nav-link" href="#">Item</a>
</nav>

See screenshot
2017-04-02_15-56-36

@mdo mdo merged commit 9a47573 into v4-dev Apr 8, 2017
@mdo mdo deleted the docs-updates branch April 8, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants