Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse - Fix check to not prevent event for input and textarea #22297

Merged
merged 2 commits into from
Mar 28, 2017

Conversation

Johann-S
Copy link
Member

Thank you @git-marijus

Close : #22296

@mdo
Copy link
Member

mdo commented Mar 28, 2017

Does the test need updating per #22296 (comment)?

@Johann-S
Copy link
Member Author

I improved my unit test

@pvdlg
Copy link
Contributor

pvdlg commented Mar 28, 2017

In you new unit test you just added assert.ok(e.isDefaultPrevented() === false) that test if the shown.bs.collapse event is prevented. That will never be prevented.

Your modification in the code prevent the event from Event.CLICK_DATA_API.
They are not the same event. Your test still doesn't do what you intend.

You should test if the <div id="collapsediv1"/> has the class show instead, to make sure that the click on the checkbox did expand the collapsible area

@Johann-S
Copy link
Member Author

Thank you @vanduynslagerp 👍 Time for me to sleep I make to much mistakes tonight

@Johann-S Johann-S merged commit fb42d6e into v4-dev Mar 28, 2017
@Johann-S Johann-S deleted the v4-fix-22296 branch March 28, 2017 22:10
@mdo mdo mentioned this pull request Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants