Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use existing key code constants in dropdown #21697

Merged
merged 3 commits into from
Jan 15, 2017
Merged

Use existing key code constants in dropdown #21697

merged 3 commits into from
Jan 15, 2017

Conversation

pvdlg
Copy link
Contributor

@pvdlg pvdlg commented Jan 13, 2017

dropdown.js#L26 defines constants for keycode and they are used throughout the module except here dropdown.js#L216

This PR use the keycode constants everywhere for more consistency.

@bardiharborow bardiharborow merged commit c80e13a into twbs:v4-dev Jan 15, 2017
@mdo mdo mentioned this pull request Jan 15, 2017
Closed
@pvdlg pvdlg deleted the dropdown-use-key-constants branch January 15, 2017 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johann-S Johann-S Johann-S approved these changes

Assignees
No one assigned
Labels
js v4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvdlg @Johann-S @bardiharborow