-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dropdown.js reliance on roles and fix keyboard navigation #21535
Merged
Merged
Changes from 20 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
ab2fc63
Dropdown: remove dependency to role="menu", role="listbox" a and li e…
pvdlg 425d156
Merge branch 'twbs/v4-dev' into dropdown-keyboard
pvdlg c4867cf
Merge branch 'twbs/v4-dev' into dropdown-keyboard
pvdlg 67958f3
Merge conflict
pvdlg eb84c03
Update dropdown unit test to new markup
pvdlg 4c2f544
Merge branch 'twbs/v4-dev' into dropdown-keyboard
pvdlg a85b80f
Merge branch 'twbs/v4-dev' into dropdown-keyboard
pvdlg 8da2815
Merge branch 'twbs/v4-dev' into dropdown-keyboard
pvdlg 9daf681
Fix test to retrieve the proper item instead of it's parent
pvdlg 59f438b
Merge branch 'twbs/v4-dev' into dropdown-keyboard
pvdlg 1a783a4
Add unit test for keyboard navigation
pvdlg 4448ca0
Refactor test to event and async
pvdlg ef2181f
Harmonize document.activeElement comparison
pvdlg 1cdd0d1
Merge branch 'twbs/v4-dev' into dropdown-keyboard
pvdlg 403f55f
Fix spacebar key in Firefox for button elements
pvdlg 4ab576a
Fixes #21941
pvdlg f5cc591
Merge branch 'twbs/v4-dev' into dropdown-keyboard
pvdlg fe72daf
Merge branch 'v4-dev' into dropdown-keyboard
pvdlg d3fbebe
Merge branch 'v4-dev' into dropdown-keyboard
pvdlg 025ddb1
Merge branch 'v4-dev' into dropdown-keyboard
pvdlg 81e12d5
Indent
pvdlg 208e038
Merge branch 'v4-dev' into dropdown-keyboard
pvdlg 2f94166
Merge branch 'v4-dev' into dropdown-keyboard
pvdlg 6301fab
Merge branch 'v4-dev' into dropdown-keyboard
patrickhlauke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the indent please ?