dropdown.js: Avoid calling jQuery('#') #21341
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling jQuery('#') is considered a syntax error in jQuery 3.
This change avoids this issue, similar to the change in arrow.js
introduced in twbs#20019.
Otherwise, 'bundle install --deployment' complains of a corrupt Gemfile.lock.
|
Note that support for v3 has mostly ceased. Please let us know if this affects v4. Pinging @mdo as we might want to backport this to v3 anyway (?). |
|
Currently it's not the case in V4 for dropdown.js |
|
Since Bootstrap v4 is not out yet, but jQuery 3 is, I would argue that this is worth considering. Otherwise, Bootstrap's dropdown.js script just throws JS syntax errors whenever included. This caused some application errors on my side. Re v4 - as far as I can tell, this is already handled there. |
|
Punting as a won't fix given v3's status. |
|
FYI it seems this was resolved in 2ccfa57. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
jQuery('#')is considered a syntax error in jQuery 3. [1]This change avoids this issue, similar to the change in
alert.jsintroduced in #20019.
[1] https://jquery.com/upgrade-guide/3.0/#breaking-change-jquery-quot-quot-and-find-quot-quot-are-invalid-syntax