Add "number" to popover content DefaultType #20210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eh, seems like it might be better to just make sure that |
|
I've considered doing so, but then I thought "function and element types must be there for a reason" (in the popover DefaultType object) so I went with the other option. Or you mean that if it's not a function nor element, it's a string? |
|
IF this is the choosen solution to fix the issue then https://github.com/twbs/bootstrap/blob/v4-dev/docs/components/popovers.md should be modified as well (line 192) |
|
@shockry maybe you can update your PR to implement solution proposed by cvrebert ? + What vanduynslagerp said |
|
Close due to : #22316 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #20193
It seems like adding another type is safe in this case