Dropdown perf - on keyboard nav, search for active item in the current dropdown rather than the whole document #19953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…own rather than the whole document
|
Refs #18454 |
|
LGTM |
This was referenced Nov 26, 2016
Closed
mdo
added a commit
that referenced
this pull request
Nov 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when navigating a dropdown with the keyboard, in order to determine the current index, this selector is used to find the active elements on the whole document.
All the dropdown-items on the page are retrieved and looped on with a call to
item.offsetWidthanditem.offsetHeightto determine if they are currently visible.With this PR the active items are searched only under the parent dropdown.
In addition it avoid the necessity to call
item.offsetWidthanditem.offsetHeight.On a side note, the keyboard navigation currently doesn't work in v4 as there is a discrepancy between the html markup (from the documentation) and the javascript. See #19864 for the fix.