Switch to stylelint.

[bardiharborow]

No description provided.

[XhmikosR]

Yup, agreed. Note for us, we could/should make use of more postcss plugins.

I'm gonna work on this later today or tomorrow and make a PR to discuss/extend my patch.

@mdo: before I spent more time with this, do you agree with the switch?

[mdo]

do you agree with the switch?

Have we discussed it at all? What's the benefit? I know we had #20402, but I don't completely remember why there was a repo for it and why our linting rules had so many changes.

[XhmikosR]

Hmm I haven't followed that PR. IMHO it makes sense to use stylelint especially if we have a config already set up. In my local branch I started from scratch but if there's a config we have control of I will use that instead.

…

On Aug 13, 2017 21:30, "Mark Otto" ***@***.***> wrote: do you agree with the switch? Have we discussed it at all? What's the benefit? I know we had #20402 <#20402>, but I don't completely remember why there was a repo for it and why our linting rules had so many changes. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#23383 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtfo3rNlpugsnpdMx6kqMlSNrXWTRks5sX0C4gaJpZM4O1lcX> .

[mdo]

if there's a config we have control of

We don't have that. It was suggested, but I don't know what it included or why that was suggested.

[XhmikosR]

I can make a config which results in no code changes and then we can make it stricter. How does that sound? We can then make a repo with our config if we want to.

…

On Aug 13, 2017 21:41, "Mark Otto" ***@***.***> wrote: if there's a config we have control of We don't have that. It was suggested, but I don't know what it included or why that was suggested. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#23383 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVtdORrAUSiEGWoqXvMfPYbQqXrchGks5sX0NXgaJpZM4O1lcX> .

[mdo]

I can make a config which results in no code changes and then we can make it stricter. How does that sound?

Still doesn't answer why we'd switch—what's the difference between the two?

[XhmikosR]

I don't know the exact differences since personally I never used scss-lint. Stylelint is very extendable and no Ruby requirement. IMO it's worth doing this as long as we match the config.

…

On Aug 13, 2017 22:48, "Mark Otto" ***@***.***> wrote: I can make a config which results in no code changes and then we can make it stricter. How does that sound? Still doesn't answer why we'd switch—what's the difference between the two? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#23383 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVVteFu3DgUcuD9jE9DM_gobcv7xVnrks5sX1MWgaJpZM4O1lcX> .

[FezVrasta]

Probably a long term decision to move away from Sass in future?

[mdo]

Stylelint is very extendable and no Ruby requirement.

Ayyy that's all you have to say to me :D.

[mdo]

Probably a long term decision to move away from Sass in future?

Yeah eventually :)

[XhmikosR]

Cool, I'll make a PR and CC you with the minimum rules so that we extend it match our needs before merging.

[bardiharborow]

Still doesn't answer why we'd switch—what's the difference between the two?

Do I need to say much more that this pretty screenshot? 😍

The main thing is that Ruby Sass, and by extension scss-lint is being gently depreciated, so stylelint is the clear migration path, in addition to being more architecturally similar to our use of ESLint for JavaScript.

[XhmikosR]

I'm gonna push my branch when I have some time to clean it up and CC you guys so that we bring the rules on par or even better with scss-lint.

[rafalp]

I would like to add my vote for this move. Ideally building css/js in Bootstrap should require npm install. I can bite the bower as its node.js too, but if my app's in python, it'll be worked with by python devs, why the heck do I need to install ruby things? ;)