Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

card-deck, Mobile screen, Unexpected margins behavior and separations in rows #22007

Closed
IgorPelevanyuk opened this issue Feb 16, 2017 · 1 comment
Closed

card-deck, Mobile screen, Unexpected margins behavior and separations in rows #22007

IgorPelevanyuk opened this issue Feb 16, 2017 · 1 comment
Labels
css has-pr v4
Milestone
v4.0.0-beta

Comments

@IgorPelevanyuk
Copy link

On narrow screens:

  1. It looks like some unnecessary margins(left) appear. (Narrow-medium screen)
  2. There is no margins(top, bottom). (Narrow screen)
  3. With four cards: three cards on one row, one card on the next row (Narrow-medium screen)
    Codepen(You will see the bug when squeeze screen horizontally):
    http://codepen.io/Gavelock/pen/vgMNOx
    Tested on Mozilla Firefox 53.0a2 (2017-02-05) (64-бит), Linux Ubuntu 16.04 LTS
@IgorPelevanyuk
Copy link
Author

Somehow related to #21976

mdo added a commit that referenced this issue Mar 28, 2017
@mdo
fixes #22007 and fixes #21976 by changing margin strategy for card de…
41f60ad 
…ck gutters
@mdo mdo added this to the v4.0.0-beta milestone Mar 28, 2017
@mdo mdo added the has-pr label Mar 28, 2017
@mdo mdo mentioned this issue Mar 28, 2017
Merged
mdo added a commit that referenced this issue Mar 28, 2017
@mdo
Fix wrapping card decks (#22289)
bebdbe4 
fixes #22007 and fixes #21976 by changing margin strategy for card deck gutters
@mdo mdo mentioned this issue Mar 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
css has-pr v4
Projects
None yet
Milestone
v4.0.0-beta
Development

No branches or pull requests
3 participants
@mdo @bardiharborow @IgorPelevanyuk