Skip to content

Commit

Permalink
Updater: Exclude tools/sanitizer.js from bootstrap_js_files
Browse files Browse the repository at this point in the history
  • Loading branch information
@glebm
glebm committed Feb 13, 2019
1 parent 0a29879 commit abf9232
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tasks/updater/js.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def update_javascript_assets

def bootstrap_js_files
@bootstrap_js_files ||= begin
src_files = get_paths_by_type('js/src', /\.js$/) - %w[index.js]
src_files = get_paths_by_type('js/src', /\.js$/) - %w[index.js tools/sanitizer.js]
imports = Deps.new
# Get the imports from the ES6 files to order requires correctly.
read_files('js/src', src_files).each do |name, content|
Expand Down

3 comments on commit abf9232

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glebm: tools/sanitizer.js is needed if you compile the src files

@glebm
Copy link
Member Author

@glebm glebm commented on abf9232 Feb 13, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XhmikosR This is just to get the list of imports in order to topologically sort them (to then turn them into sprockets //= requires in the correct order). The only JS files actually distributed with the gem are files from dist and js/dist

@XhmikosR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, OK 'cause I see Travis failing and I thought it was due to this.

Please sign in to comment.