Don't print test summary in --silent (jestjs#4106)

tushardhole · Jul 22, 2017 · 3ce4d9f · 3ce4d9f
1 parent 0b0d34b
commit 3ce4d9f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 11 deletions.
diff --git a/integration_tests/__tests__/__snapshots__/console.test.js.snap b/integration_tests/__tests__/__snapshots__/console.test.js.snap
@@ -71,6 +71,5 @@ exports[`does not print to console with --silent 3`] = `
 Tests:       1 passed, 1 total
 Snapshots:   0 total
 Time:        <<REPLACED>>
-Ran all test suites.
 "
 `;
diff --git a/integration_tests/utils.js b/integration_tests/utils.js
@@ -120,7 +120,7 @@ const createEmptyPackage = (directory, packageJson) => {
 
 const extractSummary = stdout => {
   const match = stdout.match(
-    /Test Suites:.*\nTests.*\nSnapshots.*\nTime.*\nRan all test suites.*\n*$/gm,
+    /Test Suites:.*\nTests.*\nSnapshots.*\nTime.*(\nRan all test suites)*.*\n*$/gm,
   );
   if (!match) {
     throw new Error(

diff --git a/packages/jest-cli/src/reporters/summary_reporter.js b/packages/jest-cli/src/reporters/summary_reporter.js
@@ -106,16 +106,18 @@ class SummaryReporter extends BaseReporter {
       );
 
       if (numTotalTestSuites) {
-        const testSummary = wasInterrupted
-          ? chalk.bold.red('Test run was interrupted.')
-          : this._getTestSummary(contexts, this._globalConfig);
-        this.log(
-          getSummary(aggregatedResults, {
-            estimatedTime: this._estimatedTime,
-          }) +
+        let message = getSummary(aggregatedResults, {
+          estimatedTime: this._estimatedTime,
+        });
+
+        if (!this._globalConfig.silent) {
+          message +=
             '\n' +
-            testSummary,
-        );
+            (wasInterrupted
+              ? chalk.bold.red('Test run was interrupted.')
+              : this._getTestSummary(contexts, this._globalConfig));
+        }
+        this.log(message);
       }
     }
   }