Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events and model changes #181

Merged
merged 6 commits into from
Aug 10, 2019
Merged

Events and model changes #181

merged 6 commits into from
Aug 10, 2019

Conversation

tsoporan
Copy link
Owner

#159

Proposed Changes

  • Clean up model inheritance
  • Improve consistency of timestamps as well as add duration fields
  • Add SetAdmin and touch up others
  • Weight made into a decimal
  • create_workout_event improved semantics and add events to all mutations

Signed-off-by: Titus Soporan <titus@tsoporan.com>
- Also add timestamp fields for consistency

Signed-off-by: Titus Soporan <titus@tsoporan.com>
- Consistency on time stamp fields
- Clean up inheritance

Signed-off-by: Titus Soporan <titus@tsoporan.com>
- Add SetAdmin
- Timestamp fields

Signed-off-by: Titus Soporan <titus@tsoporan.com>
- No longer store message, this will be computed later to allow more
  flexibility
- Add events througout mutations
- Improve state semantics

Signed-off-by: Titus Soporan <titus@tsoporan.com>
Signed-off-by: Titus Soporan <titus@tsoporan.com>
@tsoporan tsoporan added this to the v1.4 milestone Aug 10, 2019
@tsoporan tsoporan self-assigned this Aug 10, 2019
@tsoporan tsoporan merged commit 8beec8f into master Aug 10, 2019
@tsoporan tsoporan deleted the events-and-model-changes branch August 10, 2019 15:03
@tsoporan tsoporan mentioned this pull request Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant