Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore no overload matches error in expectError assertion #33

Merged
merged 1 commit into from
Sep 16, 2019

Conversation

orta
Copy link
Contributor

@orta orta commented Sep 13, 2019

👋 It looks like TS 3.6 has a new error code which isn't classed as being ignorable in a test, this adds that. As well as providing a bit of error info when that first diagnostics. test fails.

I'm fine with ditching the extra info on the assertion.

@SamVerschueren
Copy link
Collaborator

Hi @orta. Thanks for the PR! Could you add an extra test which validates that the error is ignored :)?

@SamVerschueren SamVerschueren mentioned this pull request Sep 14, 2019
@orta
Copy link
Contributor Author

orta commented Sep 15, 2019

No need, there are two tests which include this already 👍

@SamVerschueren
Copy link
Collaborator

Cool, totally missed that :)! Thanks for fixing.

@SamVerschueren SamVerschueren changed the title Fix master with 3.6 Ignore no overload matches error in expectError assertion Sep 16, 2019
@SamVerschueren SamVerschueren merged commit 03c170b into tsdjs:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants