Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix livecycle build #50

Merged
merged 5 commits into from
Jan 9, 2023
Merged

Fix livecycle build #50

merged 5 commits into from
Jan 9, 2023

Conversation

AssafKr
Copy link
Contributor

@AssafKr AssafKr commented Jan 9, 2023

Dockerfile was using the latest ruby version, which is currently 3.2.
There's a bug in liquid 4 which cannot work with ruby 3.2.
Set ruby to be 3.1 in the Dockerfile to make the build pass

see Shopify/liquid#1625

Copy link
Contributor

@esapir esapir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@esapir esapir merged commit 6f39eba into trywilco:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants