Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add device detection in lmes driver #298

Merged
merged 1 commit into from
Sep 20, 2024
Merged

feat: add device detection in lmes driver #298

merged 1 commit into from
Sep 20, 2024

Conversation

yhwang
Copy link
Collaborator

@yhwang yhwang commented Sep 16, 2024 •
edited
Loading

Added a new feature in the LMES driver to detect the available devices by using the PyTorch API. This feature can be disabled by passing the --detect-device false option.

fix: #297

@yhwang yhwang added feature lm-eval Issues related to LM-Eval labels Sep 16, 2024
ruivieira
ruivieira approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Sep 17, 2024
@yhwang
feat: add device detection in lmes driver
18474ba 
Added a new feature in LMES driver to detect the available
devices by using the PyTorch API. This feature can be disabled
by passing the `--detect-device false` option.

Signed-off-by: Yihong Wang <yh.wang@ibm.com>
@openshift-ci openshift-ci bot removed the lgtm label Sep 18, 2024
@yhwang
Copy link
Collaborator Author

yhwang commented Sep 18, 2024

Rebased the PR to fix the docker build error. No code change.

@yhwang yhwang closed this Sep 18, 2024
@yhwang yhwang reopened this Sep 18, 2024
@yhwang
Copy link
Collaborator Author

yhwang commented Sep 18, 2024

sorry, accidentally clicked the wrong button

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:18474baa03e9784163efa9510576107015ba79ac

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:18474baa03e9784163efa9510576107015ba79ac

📦 LMES job image: quay.io/trustyai/ta-lmes-job:18474baa03e9784163efa9510576107015ba79ac

🗂️ CI manifests

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruivieira

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit a626cf8 into trustyai-explainability:dev/lm-eval Sep 20, 2024
7 checks passed
@yhwang yhwang deleted the auto-detect-devices branch September 20, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruivieira ruivieira ruivieira approved these changes

Assignees

@ruivieira ruivieira

Labels
feature lgtm lm-eval Issues related to LM-Eval ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yhwang @ruivieira