This repository has been archived by the owner on May 5, 2022. It is now read-only.
tickers/all endpoint Implementation #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 14, 2021 05:04
anthonyw3
commented
Feb 14, 2021
| @@ -47,6 +47,9 @@ func SetupTickersAPI(engine *gin.Engine, tickers controllers.TickersController, | |||
| engine.GET("v2/market/ticker/:id", | |||
| middleware.CacheControl(d, endpoint.GetTickerHandlerV2(tickers))) | |||
|
|
|||
| engine.GET("v2/market/tickers/", | |||
There was a problem hiding this comment.
due to conflicts with the existing wildcard (gin-gonic/gin#1301) added v2/market/tickers/ instead of v2/market/tickers/all, which basically follows RESTful design
vikmeup
reviewed
Feb 17, 2021
| func (c Controller) getBaseTickers() (watchmarket.Tickers, error) { | ||
| dbTickers, err := c.database.GetBaseTickers() | ||
| if err != nil { | ||
| log.Error(err, "getBaseTickers") |
| @@ -50,6 +50,14 @@ func (c Controller) HandleTickersRequestV2(tr controllers.TickerRequestV2) (cont | |||
| return createResponseV2(tr, tickers), nil | |||
| } | |||
|
|
|||
| func (c Controller) getTickers(tr controllers.TickerRequestV2) (watchmarket.Tickers, error) { | |||
There was a problem hiding this comment.
I would avoid having fallback to all tickers if Ids not specific
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.