-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(all-contributors): add gidjin as a contributor for maintenance #2436
Conversation
@gidjin You've been maintainer for a good while now. If you want to be recognized for that work by all contributors, please feel free to merge this PR 😄 |
@@ -255,5 +256,6 @@ | |||
} | |||
], | |||
"contributorsPerLine": 7, | |||
"commitConvention": "angular" | |||
"commitConvention": "angular", | |||
"commitType": "chore(all-contributors)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this from default of docs
(all contributors added in this commit: feaa676).
This is a new/undocumented property. Opened an issue with all-contributors to get some clarity on how to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want these in our CHANGELOG.md, so let's use chore
instead of docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @brandonlenz
Adds @gidjin as a contributor for maintenance.
This was requested by brandonlenz in this comment