Merge upstream changes from create-react-app 0.9.x #84

iamlacroix · 2017-05-03T20:32:37Z

What

Merges the 0.9.x upstream changes into our fork. Via #83

Why

Keeping up with the Kardashians.

How to test

yarn add @trunkclub/build@7.0.0-alpha.1
# or
npm install @trunkclub/build@7.0.0-alpha.1

Tested with the Following Apps

…nd Errors" (facebook#1260) * Adds note on how to resolve file or directory not found errors for heroku deployments * Style tweaks

…k#1264) Browser launch can still be suppressed using BROWSER=none

…ook#1270) * facebookgh-1269: Enabling nested folder paths for project name * facebookgh-1269: Added "fs-extra" and removed "path-exists" * facebookgh-1269: Added e2e test cases to verify nested folder names

facebook#1289)

…#1311)

There’s a common tool included in Hadoop that also has a `yarn` command, which created issues for users who had Hadoop installed: * facebook#1257 * facebook#1363 Yarn also installs the command under `yarnpkg` alias (added in yarnpkg/yarn@cefa9a3) so we can use `yarnpkg` instead of `yarn` to make it more reliable. This has no effect on users who don't have Hadoop installed, but those who have won't see errors from falsely detecting Hadoop Yarn as Yarn the package manager, and they can now also install Yarn to make use of our Yarn support without the Hadoop Yarn interfering.

- create-react-app@1.0.3 - react-scripts@0.8.5

0.8.5

Array.forEach is passed the following parameters: currentValue The current element being processed in the array. index The index of the current element being processed in the array. array - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach console.log takes multiple arguments. We only want to print the first one, the actually message.

* Document Flow support Projects created by Create React App use the `babel-preset-react` which includes Flow babel plugins which introduces new syntax. This is important for users to know as it causes what used to be syntax errors to be silently suppressed because they're valid type annotations in Flow. For example if a user accidentally has `[foo: 'bar']`, Babel will silently convert it to `[foo]`. * Make it a bit clearer

) * Use a more sophisticated template for end-to-end testing. * Not publish integration tests to npm * Use "commander" for cli argv handling * Handle different scripts version forms and exits without a name given * Prepare the commands for testing with a template * Fix dev "template" path * Add various features to test * Test various features separately * Test language features * Comment unused e2e.sh lines * Add "development" tests * Test environment variables * Test webpack plugins * Replace kitchensink README * Switch integration tests from jest to mocha * Use `fs-extra` * Use the correct folders * Do some cleanup * Print a better message for `--template` * Test `npm start` with and without https * Separate fast e2e testing from kitchensink testing * Hide `--internal-testing-template` (former `--template`) CLI option

for consistency :)

* Add causes of dev server not detecting changes Add causes of `npm start` not detecting changes to Troubleshooting chapter of User Guide * Reworded slightly * Update README.md

…ebook#1437) * Added Rails link to User Guide * docs: unify sections for rails and node backend integration * docs: fix faulty link and indentation

… yarn (facebook#1441)

Per final comment in facebook#372 `Snapshot rendering should actually be pretty stable / useable after React 15.4.1. See this post for more info.`

…k#1458) ATM if react-scripts is (erroneously) declared in `dependencies` instead of `devDependencies` or isn't declared at all, the `eject` script will fail half-way. This change makes it more robust, react-scripts will be removed from either, if present.

* E2E: run tests when react is ready * Entangle e2e with callbacks * Remove unused e2e lines

- code style

* Fix npm to yarn * yarn & npm * Update index.html * Switch ordering of suggestion We should suggest NPM first for new users.

* Add linked modules test * Keep fallback after eject

* Add note about installing watchman * Update CONTRIBUTING.md

Pass the host from environment variable as argument of the devServer's listen function instead of a field of options object. Set the default host to 0.0.0.0 instead of localhost.

* Adding folder structure to help people navigate through project. It helps in resolving issues by providing brief description of each package and its purpose * Removing unnecessary packages from Folder structure heading * Update CONTRIBUTING.md

# Conflicts: # packages/eslint-config-react-app/index.js

* Node.js serving with absolute path It’s safer to use the absolute path of the directory that you want to serve, in case you run the express app from another directory. * Update README.md

…eact-app into facebookincubator-0.9.x

jblock

LGTM! I can't quite discern how this affects any changes we've made ourselves, but if it can build one of the internal apps with it, I think we're good 👍

Bigger question: can we/should we run the CRA e2e suite on Circle?

sloanelybutsurely

Thanks for taking this on!

sloanelybutsurely · 2017-05-03T20:57:03Z

packages/react-scripts/package.json

    "dotenv": "2.0.0",
    "elm-webpack-loader": "3.0.6",
-    "eslint": "3.8.1",
+    "eslint": "3.16.1",
+    "eslint-config-react-app": "^0.6.2",


We use @trunkclub/eslint-config right? No need for this?

Strange, I thought I removed it.

sloanelybutsurely · 2017-05-03T20:57:52Z

packages/react-scripts/package.json

@@ -31,49 +31,51 @@
  "dependencies": {
    "@trunkclub/eslint-config": "3.2.0",
    "@trunkclub/react-dev-utils": "1.1.0",


Will we need to update the version of @trunkclub/react-dev-utils?

Yep, good catch.

sloanelybutsurely · 2017-05-03T20:58:04Z

packages/react-scripts/package.json

    "progress-bar-webpack-plugin": "1.9.0",
    "promise": "7.1.1",
-    "react-dev-utils": "^0.4.2",
+    "react-dev-utils": "^0.5.2",


We shouldn't need this package right?

Again, strange. I'll remove it.

sloanelybutsurely · 2017-05-03T21:02:10Z

packages/react-scripts/config/webpack.config.dev.js

+  // Point ESLint to our predefined config.
+  eslint: {
+    configFile: path.join(__dirname, '../eslintrc'),
+    useEslintrc: false,


Is it possible to use emitWarning: true still? Without it, linting errors fail the dev builds entirely.

Sounds good.

iamlacroix · 2017-05-03T21:06:52Z

@jblock e2e breaks right now b/c of linting discrepancies.

sloanelybutsurely · 2017-05-03T21:13:49Z

Getting this when running tcweb-build in account_app. Looks like this is because there's a new file in utils which hasn't been published (you'll have to do so manually) and referenced in @trunkclub/build

account_app % NODE_ENV=production yarn run build
yarn run v0.23.3
$ tcweb-build build
module.js:471
    throw err;
    ^

Error: Cannot find module '@trunkclub/react-dev-utils/FileSizeReporter'
    at Function.Module._resolveFilename (module.js:469:15)
    at Function.Module._load (module.js:417:25)
    at Module.require (module.js:497:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/zach/github/trunkclub/account_app/node_modules/@trunkclub/build/scripts/build.js:33:24)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)
    at Module.runMain (module.js:604:10)
    at run (bootstrap_node.js:394:7)
    at startup (bootstrap_node.js:149:9)
    at bootstrap_node.js:509:3

iamlacroix · 2017-05-03T21:18:27Z

@zperrault That's due to the utils dep not being version bumped. I'm pushing an update in a min. (worked locally b/c of lerna link)

iamlacroix · 2017-05-03T21:24:01Z

@zperrault @jblock Ok, just published 7.0.0-alpha.1 for you to try.

eanplatter

LGTM, tho I admit I didn't read all of it

msuzoagu and others added 30 commits December 12, 2016 16:43

Heroku Deployment: Adds a note on how to resolve "File/Module Not Fou…

7a8edf0

…nd Errors" (facebook#1260) * Adds note on how to resolve file or directory not found errors for heroku deployments * Style tweaks

Remove interactive shell check when opening browser on start (faceboo…

94c912d

…k#1264) Browser launch can still be suppressed using BROWSER=none

Only gitignore dirs in root, not deep (facebook#1267)

7408e36

facebookgh-1269: Enabling nested folder paths for project name (faceb…

5fa34dd

…ook#1270) * facebookgh-1269: Enabling nested folder paths for project name * facebookgh-1269: Added "fs-extra" and removed "path-exists" * facebookgh-1269: Added e2e test cases to verify nested folder names

Remove path-exists from dependencies and replace it with fs.existsSync (

21b0044

facebook#1289)

Downgrading to compatible version of SockJS-Client (facebook#1274)

7d66ba1

Updated react-scripts babel-jest && jest packages to 18.0.0 (facebook…

ac6a4c8

…#1311)

Fixes duplicate "is" typo (facebook#1306)

e45b087

fix readme: remove double 'we' (facebook#1312)

a90e2b2

Use npm script hooks to avoid && in deploy script (facebook#1324)

4d7b754

Bump babel-loader version (facebook#1009) (facebook#1309)

2548027

Update changelog for 0.8.5

ad86746

Publish

a5b8389

- create-react-app@1.0.3 - react-scripts@0.8.5

Merge pull request facebook#1367 from facebookincubator/0.8.x

11cc5ae

0.8.5

Add missing import in react-dev-utils README.md (facebook#1369)

d29fb00

webpack-dev-server patch for 'still-ok' success status (facebook#1377)

17bb8d4

replace two space syntax with <br> tag (facebook#1393)

adce379

for consistency :)

Add causes of dev server not detecting changes (facebook#1422)

65bde54

* Add causes of dev server not detecting changes Add causes of `npm start` not detecting changes to Troubleshooting chapter of User Guide * Reworded slightly * Update README.md

Added links to tutorials for integrating cra with an api backend (fac…

3bb31cc

…ebook#1437) * Added Rails link to User Guide * docs: unify sections for rails and node backend integration * docs: fix faulty link and indentation

Added babel-runtime dependency to deduplicate dependencies when using…

dbb7ffe

… yarn (facebook#1441)

Bump Jest version (facebook#1432)

da321b2

Readme: Removes experimental from Jest snapshot (facebook#1453)

dd788b6

Per final comment in facebook#372 `Snapshot rendering should actually be pretty stable / useable after React 15.4.1. See this post for more info.`

E2e jsdom fix (facebook#1470)

1d586aa

* E2E: run tests when react is ready * Entangle e2e with callbacks * Remove unused e2e lines

- import expect and expect flow (facebook#1463)

8964dd6

- code style

tmos and others added 14 commits April 14, 2017 22:57

Suggest Yarn in HTML template (facebook#1911)

df7c067

* Fix npm to yarn * yarn & npm * Update index.html * Switch ordering of suggestion We should suggest NPM first for new users.

Note that only jest-enzyme@2.x is compatible

40d1b17

Add sku to the list of alternatives (facebook#1962)

8bd395a

Update information in User Guide for Enzyme dependency (facebook#1982)

3d8c820

Ensure proxy url starts with http:// or https:// (facebook#1890)

10dfd89

Update ansi-html to fix facebook#1881

4b92fd3

Add linked modules test (0.9.x) (facebook#1912)

51f34f1

* Add linked modules test * Keep fallback after eject

Add note about installing watchman (facebook#1950)

19e0386

* Add note about installing watchman * Update CONTRIBUTING.md

Start the dev server at the specified host

604519a

Pass the host from environment variable as argument of the devServer's listen function instead of a field of options object. Set the default host to 0.0.0.0 instead of localhost.

Relax label rules (facebook#1989)

a0c37ca

# Conflicts: # packages/eslint-config-react-app/index.js

Update doc server example to work from any directory (facebook#1988)

144f03b

* Node.js serving with absolute path It’s safer to use the absolute path of the directory that you want to serve, in case you run the express app from another directory. * Update README.md

Merge branch '0.9.x' of https://github.com/facebookincubator/create-r…

6a8b78b

…eact-app into facebookincubator-0.9.x

Fix config discrepancies after merging from upstream v0.9.x

e16ff2f

iamlacroix requested review from jblock, sloanelybutsurely, eanplatter and littleredninja May 3, 2017 20:32

jblock approved these changes May 3, 2017

View reviewed changes

sloanelybutsurely reviewed May 3, 2017

View reviewed changes

Minor fixes per feedback for upstream merging

5e19490

eanplatter approved these changes May 4, 2017

View reviewed changes

iamlacroix and others added 2 commits May 4, 2017 13:36

Fix import from incorrect module

5c79733

Release v7.0.0

61c21d8

iamlacroix merged commit 7a11edd into master May 16, 2017

imjoshdean-tc deleted the facebookincubator-0.9.x branch January 28, 2019 21:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge upstream changes from create-react-app 0.9.x #84

Merge upstream changes from create-react-app 0.9.x #84

iamlacroix commented May 3, 2017 •

edited

Loading

jblock left a comment

sloanelybutsurely left a comment

sloanelybutsurely May 3, 2017

iamlacroix May 3, 2017

sloanelybutsurely May 3, 2017

iamlacroix May 3, 2017

sloanelybutsurely May 3, 2017

iamlacroix May 3, 2017

sloanelybutsurely May 3, 2017

iamlacroix May 3, 2017

iamlacroix commented May 3, 2017

sloanelybutsurely commented May 3, 2017

iamlacroix commented May 3, 2017 •

edited

Loading

iamlacroix commented May 3, 2017

eanplatter left a comment

Merge upstream changes from create-react-app 0.9.x #84

Merge upstream changes from create-react-app 0.9.x #84

Conversation

iamlacroix commented May 3, 2017 • edited Loading

What

Why

How to test

Tested with the Following Apps

jblock left a comment

Choose a reason for hiding this comment

sloanelybutsurely left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamlacroix commented May 3, 2017

sloanelybutsurely commented May 3, 2017

iamlacroix commented May 3, 2017 • edited Loading

iamlacroix commented May 3, 2017

eanplatter left a comment

Choose a reason for hiding this comment

iamlacroix commented May 3, 2017 •

edited

Loading

iamlacroix commented May 3, 2017 •

edited

Loading