Major refactor of pipeline system to support next wave of features. #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All assets which are to be processed by trunk must now be declared as
HTML
link
elements as such:<link data-trunk rel="rust|sass|..." data-attr0 data-attr1/>
.The links may appear anywhere in the HTML and Trunk will process them and
replace them or delete them based on the associated pipeline's output.
If the link element does not have the
data-trunk
attribute, it will notbe processed.
The
--manifest-path
flag has been removed in favor of the new linkstyle:
<link data-trunk rel="rust" href="path/to/Cargo.toml"/>
. This is optional,and will default to the Cargo.toml of the source HTML's parent dir if
not specified.
Update README describing new asset pipeline declaration pattern.
closes #50
closes #72
todo
head
, then it should be replaced there, if declared in thebody
then it should be replaced there.data-trunk
links are processed, their HTML will be replaced based on where they exist in the DOM. So if links need to appear in the HTML body for including the WASM/JS, adding thedata-trunk
link to the HTML body will solve that problem.rust-worker
asset type. Thehref
attr should behave exactly as it does for therust
asset type.for anyone willing to review
Please take a look at the rendered README file. The main thing which needs review/feedback here is the pattern which I've landed on for declaring assets (which is mostly discussed in the assets section of the README).