Ensure eth_sendTransaction is fully asynchronous (#294)

trufflesuite · Feb 1, 2019 · e1d184d · e1d184d
1 parent 02bf9e7
commit e1d184d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/lib/provider.js b/lib/provider.js
@@ -111,7 +111,7 @@ Provider.prototype.send = function(payload, callback) {
             .join("\n <   ")
       );
     }
-    callback(response.error ? err : null, response);
+    process.nextTick(() => callback(response.error ? err : null, response));
   };
 
   if (self.options.verbose) {

diff --git a/test/accounts.js b/test/accounts.js
@@ -43,18 +43,13 @@ describe("Accounts", function() {
         value: web3.utils.toWei(new BN(1), "ether"),
         gasLimit: 90000
       },
-      function(err, tx) {
+      function(err) {
         if (!err) {
           return done(
             new Error("We expected the account to be locked, which should throw an error when sending a transaction")
           );
         }
-        assert(
-          err.message.toLowerCase().indexOf("could not unlock signer account") >= 0,
-          "Expected error message containing \"could not unlock signer account\" " +
-            "(case insensitive check). Received the following error message, instead. " +
-            `"${err.message}"`
-        );
+        assert.strictEqual(err.message, "signer account is locked");
         done();
       }
     );