[analyze] Add Analyzer interface for Gitlab #3232
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
approved these changes
Aug 23, 2024
abmussani
force-pushed
the
impl-data-model-gitlab
branch
from
ccc7f7c
to
ca8ac04
Compare
mcastorina
reviewed
Sep 6, 2024
There was a problem hiding this comment.
The code looks good but the test isn't passing. It looks like the gitlab token is expired:
» curl 'https://gitlab.com/api/v4/personal_access_tokens/self' -H "Private-Token: $GITLAB_TOKEN"
{
"error": "invalid_token",
"error_description": "Token is expired. You can either do re-authorization or token refresh."
}
abmussani
force-pushed
the
impl-data-model-gitlab
branch
from
3b5b769
to
051aadf
Compare
to make more unique FullyQualifiedName, Ids are added for resources.
|
@mcastorina I have updated the active |
mcastorina
reviewed
Sep 13, 2024
| Bindings: []analyzers.Binding{}, | ||
| } | ||
|
|
||
| // Add token and it's permissions to bindings |
There was a problem hiding this comment.
Are we sure token should be a resource here? Does the credential we're analyzing grant permission to perform actions on the token?
| // Add token and it's permissions to bindings | ||
| tokenResource := analyzers.Resource{ | ||
| Name: info.AccessToken.Name, | ||
| FullyQualifiedName: fmt.Sprintf("github.com/token/%d", info.AccessToken.ID), |
There was a problem hiding this comment.
"github.com" should probably be "gitlab.com" here
| FullyQualifiedName: fmt.Sprintf("github.com/token/%d", info.AccessToken.ID), | ||
| Type: "access_token", | ||
| Metadata: map[string]any{ | ||
| "last_used_at": info.AccessToken.LastUsedAt, |
There was a problem hiding this comment.
Since we don't update resources, this value can easily become stale. I think it's best to remove it.
| for _, project := range info.Projects { | ||
| projectResource := analyzers.Resource{ | ||
| Name: project.NameWithNamespace, | ||
| FullyQualifiedName: fmt.Sprintf("github.com/project/%d", project.ID), |
There was a problem hiding this comment.
Same here github.com -> gitlab.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR implements the analyzer interface for Gitlab.
Checklist:
make test-community)?make lintthis requires golangci-lint)?