-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test compilation errors #2964
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you β€οΈ
haraldh
added a commit
to matter-labs/vault-auth-tee
that referenced
this pull request
Jun 24, 2024
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [trufflesecurity/trufflehog](https://togithub.com/trufflesecurity/trufflehog) | action | patch | `v3.78.1` -> `v3.78.2` | --- ### Release Notes <details> <summary>trufflesecurity/trufflehog (trufflesecurity/trufflehog)</summary> ### [`v3.78.2`](https://togithub.com/trufflesecurity/trufflehog/releases/tag/v3.78.2) [Compare Source](https://togithub.com/trufflesecurity/trufflehog/compare/v3.78.1...v3.78.2) #### What's Changed - fix(deps): update golang.org/x/exp digest to [`fc45aab`](https://togithub.com/trufflesecurity/trufflehog/commit/fc45aab) by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2931 - adding twitter + Consumer key detector by [@​abmussani](https://togithub.com/abmussani) in [trufflesecurity/trufflehog#2963 - Fix test compilation errors by [@​rgmz](https://togithub.com/rgmz) in [trufflesecurity/trufflehog#2964 - Modularize scanning engine by [@​ahrav](https://togithub.com/ahrav) in [trufflesecurity/trufflehog#2887 - adding eraser ai detector by [@​0x1](https://togithub.com/0x1) in [trufflesecurity/trufflehog#2961 - \[feat] - add metrics to the Engine by [@​ahrav](https://togithub.com/ahrav) in [trufflesecurity/trufflehog#2968 - Double archive `maxDepth` until bug is fixed by [@​rgmz](https://togithub.com/rgmz) in [trufflesecurity/trufflehog#2965 - Return match/reason from `detectors.IsKnownFalsePositive` by [@​rgmz](https://togithub.com/rgmz) in [trufflesecurity/trufflehog#2969 - Fix integration tests by [@​rosecodym](https://togithub.com/rosecodym) in [trufflesecurity/trufflehog#2970 - \[fix] - implement MaxSecretSizeProvider for `auth0managementapitoken` detector by [@​ahrav](https://togithub.com/ahrav) in [trufflesecurity/trufflehog#2953 - Patch archived dependency by [@​dustin-decker](https://togithub.com/dustin-decker) in [trufflesecurity/trufflehog#2971 - fix(deps): update module github.com/aws/aws-sdk-go to v1.54.2 by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2962 - fix(deps): update golang.org/x/exp digest to [`7f521ea`](https://togithub.com/trufflesecurity/trufflehog/commit/7f521ea) by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2972 - fix(deps): update module github.com/google/go-containerregistry to v0.19.2 by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2973 - fix(deps): update module go.mongodb.org/mongo-driver to v1.15.1 by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2975 - fix(deps): update module cloud.google.com/go/storage to v1.42.0 by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2977 - fix(deps): update module github.com/bradleyfalzon/ghinstallation/v2 to v2.11.0 by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2980 - fix(deps): update module github.com/elastic/go-elasticsearch/v8 to v8.14.0 by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2981 - fix(deps): update module github.com/getsentry/sentry-go to v0.28.1 by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2986 - \[feat] - Add Option to Retain False Positives During Detection by [@​ahrav](https://togithub.com/ahrav) in [trufflesecurity/trufflehog#2967 - fix(deps): update module google.golang.org/api to v0.185.0 by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2987 - clone more refs by [@​zricethezav](https://togithub.com/zricethezav) in [trufflesecurity/trufflehog#2988 - fix(deps): update module github.com/aws/aws-sdk-go to v1.54.5 by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2992 - Disambiguate step names in `detector-tests` workflow by [@​rgmz](https://togithub.com/rgmz) in [trufflesecurity/trufflehog#2989 - fix(deps): update module github.com/googleapis/gax-go/v2 to v2.12.5 by [@​renovate](https://togithub.com/renovate) in [trufflesecurity/trufflehog#2993 **Full Changelog**: trufflesecurity/trufflehog@v3.78.1...v3.78.2 </details> --- ### Configuration π **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/vault-auth-tee). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
PRs #2812 and #2930 inadvertently broke a few tests.
This wasn't noticed because Go doesn't seem to have a way to compile all tests/tags. The closest you can get is manually specifying all the tags and running a pattern that won't be matched.π€·ββοΈ
Checklist:
make test-community
)?make lint
this requires golangci-lint)?