improve langchain prompting using native messages #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
![ellipsis-dev[bot]](https://github.com/avatars/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 30ddaac in 1 minute and 50 seconds
More details
- Looked at
45lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_XUxQ4UyEIADJVjfl
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
sfc-gh-jreini
approved these changes
Jun 11, 2024
Merged
sfc-gh-dhuang
pushed a commit
that referenced
this pull request
Jun 28, 2024
Co-authored-by: Josh Reini <josh.reini@snowflake.com>
sfc-gh-dhuang
pushed a commit
that referenced
this pull request
Jul 1, 2024
Co-authored-by: Josh Reini <josh.reini@snowflake.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when using LangChain chain as eval, the messages are serialized as json in the llm prompt, giving really bad results.
Instead langchain llm offers a method
predict_messagesthat handles the prompt in a more performant way.Changes:
This directly impact all the builtin feedback functions
Summary:
Enhances LangChain prompting by using native
predict_messagesand a new helper function_convert_messagefor message conversion.Key points:
_convert_messageto convert dict toBaseMessagepredict_messagesfor better performanceGenerated with ❤️ by ellipsis.dev