Viscous CFL: TreeMesh{1}
#2035
Viscous CFL: TreeMesh{1}
#2035
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2035 +/- ##
========================================
Coverage 96.23% 96.23%
========================================
Files 462 464 +2
Lines 37084 37184 +100
========================================
+ Hits 35687 35784 +97
- Misses 1397 1400 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| # NOTE: | ||
| # For non-zero `cfl_diffusive`, `semi` is expected to be a `SemidiscretizationHyperbolicParabolic`. | ||
| if cfl_diffusive > 0.0 |
There was a problem hiding this comment.
This is a bit of a hack, as this would crash if someone supplies cfl_diffusive for a simulation without parabolic equations.
I first tried another if-clause if hasfield(semi, :equations_parabolic) which unfortunately gave errors in some particular cases.
This adds a viscous CFL condition, see #1147 for the 1D TreeMesh.
In this draft, the user is expected to supply to CFL values for each contribution (convective & diffusive).
There are couple open points:
Semidiscretizationused and store the diffusive cfl number also for the convection-dominated case (and never use it).By executing the convergence study, it is quite nicely shown that at some point of refinement the viscous CFL becomes active (note that for the last refinement the number of timesteps increases by a factor of 4, while before the number of timesteps only doubles):