-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second-Order Finite Volume Integral in 1D #2022
base: main
Are you sure you want to change the base?
Second-Order Finite Volume Integral in 1D #2022
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2022 +/- ##
==========================================
- Coverage 96.23% 96.22% -0.01%
==========================================
Files 462 463 +1
Lines 37084 37169 +85
==========================================
+ Hits 35687 35764 +77
- Misses 1397 1405 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This picks up the #433 draft by Gregor and updates it to the current structure. Could serve as a starting point to examine the effect of using an O2 FV scheme in the subcell capturing
VolumeIntegralShockCapturingHG
.2D/3D will probably follow in some time, but this should also be trivial so if anyone else would like to pick this up, feel free to do so.
Also, this is helpful if one would like to bring a classic second order finite volume solver into Trixi at some point.
Xref: #425
Convergence studies:
Not really sure why
superbee
is so bad.