-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump StartUpDG.jl compat to 1.1+ #2001
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2001 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 470 470
Lines 37447 37447
=======================================
Hits 36070 36070
Misses 1377 1377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks! Looks like the CI failure is real:
|
Thanks! I should be able to get to this after the holiday (July 4 in the US) |
It turns out there was a bug in Dict{Symbol, Any} with 3 entries:
:variables => ("rho", "rho_v1", "rho_v2", "rho_v3", "rho_e")
:l2 => [0.438461, 0.607849, 0.607727, 0.414621, 0.482715]
:linf => [0.240406, 0.676716, 0.68089, 0.144242, 0.296871] Fixing it using (what will be) v1.1.4 of StartUpDG gives Dict{Symbol, Any} with 3 entries:
:variables => ("rho", "rho_v1", "rho_v2", "rho_v3", "rho_e")
:l2 => [3.23863, 3.60149, 3.60946, 3.26518, 3.70695]
:linf => [3.30159, 3.5868, 3.5791, 3.39908, 3.75305] |
this is weird - Julia is loading SciMLBase v2.50.5 for me locally, which includes a `discType` parameter. https://github.com/SciML/SciMLBase.jl/blob/12f30308a4f4959dd6bbf97efc1f600621546cf4/src/solutions/ode_solutions.jl#L108C65-L109 However, I don't think any StartUpDG changes should have triggered this, so I'm not sure why these tests are failing now
This reverts commit f2909f9.
This reverts commit 4abd2fd.
This should be ready to review now. It took a while to figure out what was breaking CI in StartUpDG.jl, but I found a bug and a broken test in the process. I think I cleaned up all the remaining spurious changes I made along the way as well now. |
Currently, StartUpDG.jl <1.1.0 imports
NamedArrayPartition
from RecursiveArrayTools.jl. Due to compat bounds put in place because of #1789, this prevents us from using newer versions of StartUpDG.jl.This PR moves
NamedArrayPartition
back into StartUpDG.jl and lowers the compat requirement on RecursiveArrayTools.jl, hopefully making it compatible with Trixi.jl again.