-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subcell limiting support for P4estMesh #1954
Conversation
Review checklistThis checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging. Purpose and scope
Code quality
Documentation
Testing
Performance
Verification
Created with ❤️ by the Trixi.jl community. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1954 +/- ##
==========================================
+ Coverage 96.30% 96.32% +0.02%
==========================================
Files 467 470 +3
Lines 37265 37446 +181
==========================================
+ Hits 35888 36069 +181
Misses 1377 1377
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!! 🙂
Here a couple of comments/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, this is ready to merge. What do you think, @sloede?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If @amrueda is happy as well and all tests have passed, please feel free to merge 😊
This PR includes:
calc_bounds_twosided_interface
andcalc_bounds_onesided_interface
for P4estMeshget_boundary_outer_state
to allow normal directions, inner values (for slip wall), ...save_bounds_check_errors
fromsubcell_bounds_check_2d.jl
tosubcell_bounds_check.jl
TODO:
calc_bounds_twosided_boundary
for Periodic boundaries.No support for non-conservative terms implemented yet.
Example: Supersonic cylinder
![rho](https://private-user-images.githubusercontent.com/74359358/334104098-58048bc1-f706-47de-b6f8-c828addfe90e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMjc2MjgsIm5iZiI6MTcyNjEyNzMyOCwicGF0aCI6Ii83NDM1OTM1OC8zMzQxMDQwOTgtNTgwNDhiYzEtZjcwNi00N2RlLWI2ZjgtYzgyOGFkZGZlOTBlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDA3NDg0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk4N2JlYjVjZTk0ZGM2MTBlMWI5NmQ4OGRkYTViOThhYWVhMjUwZjc5ODljZjgwNzhjZjg3NDkyYmEyOWIxZjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Hvy1UtNVQXbtPphzjtknHkpxK4NGFRTOfWri3KSSQgI)
![alpha](https://private-user-images.githubusercontent.com/74359358/334104126-454f03fc-e8b6-4c1d-9a51-fb22cadc5b47.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxMjc2MjgsIm5iZiI6MTcyNjEyNzMyOCwicGF0aCI6Ii83NDM1OTM1OC8zMzQxMDQxMjYtNDU0ZjAzZmMtZThiNi00YzFkLTlhNTEtZmIyMmNhZGM1YjQ3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDA3NDg0OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdiZDM0ZGVlZmEwNjBhZTJlZDljMGMzOTA4OWI5MmE2ZmM5MzQzNzU5OTE3YmU4OWNhZmU3MmY1MjI3MTY0YTkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.JOCpsslNKDVx764UsUh3M0JgVadTeg39sCM2AHyNTdA)
Local two-sided limiting of density, positivity of pressure and local onesided limiting of entropy (guermond et al)
No AMR. Initial refinement level for given mesh of 3 -> 35904 elements; polynomial degree of 3