Mappings with variables outside of scope #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willothy
requested changes
Jan 15, 2024
| --Remove wrapping parens and wrap in table and unpack - issue #81 | ||
| strObj = strObj:gsub("^%s*%(%s*", ""):gsub("%s*%)%s*$", "") | ||
| return loadstring("return {" .. strObj .. "}")() | ||
| local func = loadstring("return {" .. strObj .. "}") |
There was a problem hiding this comment.
I think you may need upvalues as well, and this could still throw an error in some cases I think, like when the value returned here is not what's expected.
| end | ||
| local wkMapping = which_key.parse(unpack(tableObj)) | ||
|
|
||
| for _, mapping in ipairs(wkMapping) do | ||
| if mapping.cmd == nil then | ||
| mapping.cmd = "Function uses out of scope variables" |
There was a problem hiding this comment.
I think this should go on a separate error prop that can be displayed if the main prop is nil. Feels a bit weird to just include an error message without any kind of flag for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a mapping is done via whichkey, we pass the table into whichkey for parsing.
If there are assignments that are done outside of the functional call we can't capture them. This means the loadfile() fails.
I don't know how to handle this
Here is a failing test to demonstrate the problem
Related to issue #81