Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect using SSID with prefix if on iOS >= 13 #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

saoron
Copy link
Contributor

@saoron saoron commented Dec 10, 2019

Description of the Change

iOS 13 introduced a new way to connect with an SSID prefix, this will automatically use the prefix method if on iOS 13

@digaus
Copy link

digaus commented Dec 21, 2019

This looks nice !!

This functionality would allow me to just pass the prefix of smartphone devices (which are the same) to the connect function and it will try to connect to a network with that prefix?

What happens if there are multiple networks with this prefix?

@digaus
Copy link

digaus commented Dec 23, 2019

Your PR won't work. It will always return an error because the prefix SSID is not the SSID which you are connected to.

digaus@b84507a

Tested with my iot devices. Working as expected.

@digaus
Copy link

digaus commented Dec 24, 2019

@saoran

You also need to modify (void)iOSConnectOpenNetwork:(CDVInvokedUrlCommand*)command

@arsenal942
Copy link
Collaborator

@saoron I agree with @digaus - Let us know once fixed up

@digaus
Copy link

digaus commented Jan 10, 2020

@arsenal942

Might als be better to use a second plugin call for it but migrate the connect without password into the connect call.

-> connect and connectPrefix

@tripflex
Copy link
Owner

@digaus would you mind submitting a PR with the fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants