Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect authentication type on Android #91

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

digaus
Copy link

@digaus digaus commented Jul 20, 2019

Description of the Change

Differentiate between different network authentication types when retrieving networks by SSID. This is necessary because android stores multiple networks with same SSID but different types.

Benefits

Fixes a problem where one cannot connect to an unsecured network when there is a configuartion with WPA/WPA2 already configured.

@digaus
Copy link
Author

digaus commented Sep 23, 2019

@tripflex
Can you look into this?

for (WifiConfiguration test : currentNetworks) {
if (test.SSID != null && test.SSID.equals(ssid)) {
networkId = test.networkId;
if (test.SSID != null) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest changing test to something more appropriate.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty trivial change but I don't like variables test in production code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow forgot this PR was open ^^currently messing with master to get IP on iOS. will refactor for better PR later

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - Did you ever get around to fixing it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants