Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Driver][sycl-xocc] Experimental SYCL Driver Patch, More Aligned With OpenMP and xocc script/ToolChain refactoring #24

Merged

Commits on May 3, 2019

  1. Configuration menu
    Copy the full SHA
    98a6110 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7042a53 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    44b5fba View commit details
    Browse the repository at this point in the history
  4. [SYCL] XOCC ToolChain Fix

    Need to instantiate the linker and assembler slightly differently now 
    that we're no longer using the internal GetTools call.
    agozillon committed May 3, 2019
    Configuration menu
    Copy the full SHA
    f65f76d View commit details
    Browse the repository at this point in the history
  5. [SYCL] Removing requirement to give -fsycl-xocc-device as command lin…

    …e argument
    
    Unfortunately, while the user is no longer required to specify a command
    line argument to the user, the compiler still needs a new Option for
    information to be pushed from the Driver onto both the host and device
    for now. If it's just device related, it would be feasible to check the
    Target triple. Sadly the host invocation doesn't contain any knowledge
    of the offloaded triple from what I can tell (aux-triple would be nice
    to use, but it seems this is largelly used to pass host triple
    information to device offloading passes and not vice-versa).
    
    Changed -fsycl-xocc-device -> -fsycl-xocc, as it currently enforces both
    host and device related tweaks (mainly forces the host definition of
    __SYCL_XILINX_ONLY__, which I think should be refactored out long term
    for a runtime solution if feasible).
    
    Moved option -fsycl-xocc from Options.td to CC1Options.td, as it's more
    "Clang" specific rather than part of the driver frontend at the moment
    (shouldn't really be read by the driver/isn't at the moment). Perhaps, a
    bit pedantic...
    
    Adding a test to check internal compiler defines that should print some
    messages based on some defines that should be generated by the compiler.
    agozillon committed May 3, 2019
    Configuration menu
    Copy the full SHA
    2c5dd86 View commit details
    Browse the repository at this point in the history
  6. [SYCL] Remove Unrequired XOCC Assembler Stage

    Should be an NFC, but simplifies and cleans up the implementation a 
    little.
    agozillon committed May 3, 2019
    Configuration menu
    Copy the full SHA
    b175432 View commit details
    Browse the repository at this point in the history
  7. [SYCL][NFC] Large XOCC Tool Refactor

    This shouldn't change any existing functionallity, it is cleaning the 
    driver by:
     * Moving construct commands from the XOCC Tool Chain into the sycl-xocc 
    shell script, resulting in 1 single command for the Tool Chain to the 
    script
     * Combining the XOCC Compiler and Linker Command phases into one, in 
    both the Script and commands
    
    Overall this should result in a much easier to read and understand set 
    of tools to build on.
    agozillon committed May 3, 2019
    Configuration menu
    Copy the full SHA
    209f423 View commit details
    Browse the repository at this point in the history
  8. [SYCL][NFC] Trivial documentation and test edits

    * Fixed documentation and tests to use new fsycl-targets
    * Added RUN: true to the top of new test so that it passes by default 
    with check-all
    * Removed some old todo's from XOCC.h
    agozillon committed May 3, 2019
    Configuration menu
    Copy the full SHA
    b4380a4 View commit details
    Browse the repository at this point in the history
  9. [SYCL][NFC] Change getOffloadingDeviceToolChain to categorize by Offl…

    …oadKind
    
    I think this makes more snese than the previous version that used the 
    Arch > OS categorization method like GetToolChain.
    
    Open to changing it back though or altering it to a different 
    categorization method!
    agozillon committed May 3, 2019
    Configuration menu
    Copy the full SHA
    007fb23 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    352e79d View commit details
    Browse the repository at this point in the history

Commits on May 4, 2019

  1. [SYCL][NFC] Addressing more review comments

    Largelly just tidying up the new test and documentation, nothing 
    important.
    agozillon committed May 4, 2019
    Configuration menu
    Copy the full SHA
    2e741e2 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2019

  1. Configuration menu
    Copy the full SHA
    834df22 View commit details
    Browse the repository at this point in the history