Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy support to search and scraper #104

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ramicaza
Copy link

@ramicaza ramicaza commented Jul 4, 2023

The hacky patch I mentioned in #97 couldn't get me all the way so I decided to fork. Hope I didn't miss anything while adding the proxy.

@italianconcerto
Copy link

Hey, is it possible to merge this branch?

@italianconcerto
Copy link

@trevorhobenshield

@@ -565,7 +566,7 @@ async def _paginate(self, client: AsyncClient, operation: tuple, **kwargs):
ids = set(find_key(initial_data, 'rest_id'))
cursor = get_cursor(initial_data)
except Exception as e:
self.logger.error('Failed to get initial pagination data', e)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this intentional?

@sdfgsdfsdf
Copy link

is it possible to merge this branch?

@trevorhobenshield trevorhobenshield marked this pull request as draft February 10, 2024 15:06
@trevorhobenshield trevorhobenshield marked this pull request as ready for review February 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants