feat(grammar): capture comment directives #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds additional capture group for comment directives. The purpose is to allow editors relying on tree-sitter for higlight to provide different higlight for directive comments that fullfil other than documenting purpose in the code. The syntax of the directive comments is described in the [syntax](https://tip.golang.org/doc/comment#syntax) section of the _comment_ documentation.
matoous
changed the title
aryx
approved these changes
Dec 6, 2022
|
@aryx sorry, seems like my change didn't pass the pipeline: https://github.com/tree-sitter/tree-sitter-go/actions/runs/3628335707/jobs/6119224709. I didn't notice these tests. I can prepare revert if necessary (and will take a look at the changes one more time). |
|
yes please send a revert PR |
|
also @dcreager @maxbrunsfeld why those github actions are not run on the PR itself? |
|
It used to work ... who changed it? |
aryx
added a commit
that referenced
this pull request
Dec 6, 2022
Revert "Merge pull request #97 from matoous/md/comment-directives"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional capture group for comment directives. The purpose is to allow editors relying on tree-sitter for higlight to provide different higlight for directive comments that fullfil other than documenting purpose in the code.
The syntax of the directive comments is described in the syntax section of the comment documentation.
Checklist: