Many fixes #117
Closed
Many fixes #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
special characters such as Chinese letters weren't parsing properly before
… priority The lower priority allows for multiple return types to be parsed as two types rather than a second map return type being split into an identifier `map` followed by an array type
…_simple_type The _simple_type covers both constraint_term and interface_type_name, no point having both when we can just alias _simple_type to constraint_elem
|
@amaanq would it be possible to have one separate PR for each of those fixes? I know it's tedious, but then it's easier to revert one individually if 2 months from now someone find a regression. It's also far easier to review. |
|
A few of the linked issues are the same problem, I'll split it into two, one for bug fixes/precedence issues and one for the added types/fixed struct elements |
5 tasks
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Closes #46
Closes #62
Closes #94
Closes #95
Closes #104
Closes #106
Closes #107