Require Ruby >= 2.1.0 #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @alexcwatt I support this. I didn't realize u had made this PR and I just did a release without this. Let's let this marinate here for a week or so and if nobody comes out of the woodwork we'll do this.. |
|
@alexcwatt any chance you can resolve these conflicts. Sorry. I'm hoping to put together a release soon and would like to include this. |
alexcwatt
force-pushed
the
change-ruby-version
branch
from
9dc9742
to
5f00ba5
Compare
|
@joshuacronemeyer updated and looks like CI passed! This one might be easier to review with whitespace hidden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#419 had to check for Ruby >= 2.1.0, but maybe this is a good time to bump the Ruby version in the library and cut a release?
(I also noticed CI seems to test back to 2.3, so maybe we consider going up even further.)