Rewrite UI and add jest tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmosca
force-pushed
the
travelperk-rewrite-ui
branch
from
7874b85
to
167db2b
Compare
robmosca
force-pushed
the
travelperk-rewrite-ui
branch
from
167db2b
to
19171d9
Compare
|
Cool UI ✨ ! |
robmosca
requested review from
namelivia and
ivan-navarro-75
and removed request for
namelivia and
ivan-navarro-75
namelivia
reviewed
Oct 2, 2023
| @@ -5,7 +5,7 @@ | |||
| "fixed": [], | |||
| "linked": [], | |||
| "access": "restricted", | |||
| "baseBranch": "origin/main", | |||
| "baseBranch": "origin/travelperk", | |||
There was a problem hiding this comment.
I recall seeing a post from the security team the other day stating we should not use other branch names than main
There was a problem hiding this comment.
Yes, I already talked to them, and forked repos will need to be treated differently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says:
ImportMapOverridesContextto simplify handling of state