Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for #219 #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Workaround for #219 #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions api/hooks/permissions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,18 @@ class Permissions extends Marlinspike {
if (!_.isObject(sails.config.permissions)) sails.config.permissions = { }

/**
* Local cache of Model name -> id mappings to avoid excessive database lookups.
* workaround for #219:
* If your _actually_ want to populate blueprint models, you should set `populateForce` filed in config
*/
this.sails.config.blueprints.populate = false
var populateForce = this.sails.config.blueprints.populateForce;
if (populateForce) {
this.sails.config.blueprints.populate = !!populateForce;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know about side-effects of using !! to coercion to boolean value.

But i think it's pretty legal to expect not only exactly true value but all "truish" like 1, {}, or 0, ""

} else {
/**
* Local cache of Model name -> id mappings to avoid excessive database lookups.
*/
this.sails.config.blueprints.populate = false
}
}

initialize (next) {
Expand Down