New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust field names of JSON output in compliance with OTLP/HTTP spec #327

Merged

janstenpickle merged 1 commit into trace4cats:master from sam-tombury:fix/otel-json-spec

Aug 9, 2023

Contributor

sam-tombury commented Aug 9, 2023

OTLP/HTTP spec states that JSON field names should be lowerCamelCased.

See JSON Protobuf Encoding, in particular:

The keys of JSON objects are field names converted to lowerCamelCase. Original field names are not valid to use as keys for JSON objects. For example, this is a valid JSON representation of a Resource: { "attributes": {...}, "droppedAttributesCount": 123 }, and this is NOT a valid representation: { "attributes": {...}, "dropped_attributes_count": 123 }.


          Fix compliance with OTLP/HTTP spec

fdae2c8

JSON field names should be lowerCamelCased

janstenpickle approved these changes

View reviewed changes

Contributor

janstenpickle left a comment

Looks good, thanks!

janstenpickle merged commit 3b8bd43 into trace4cats:master

9 checks passed

sam-tombury deleted the fix/otel-json-spec branch

August 9, 2023 18:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet