Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust OTEL JSON format to breaking changes #278

Merged
merged 2 commits into from
May 17, 2023

Conversation

ybasket
Copy link
Contributor

@ybasket ybasket commented Apr 19, 2023

The OTEL trace format had breaking changes a while back, so to work with up-to-date collectors and trace backends like Jaeger, it has to be adjusted.

Tested with OTEL collector 0.74 and a relatively recent Jaeger.

The OTEL trace format had breaking changes a while back, so to work with up-to-date collectors and trace backends like Jaeger, it has to be adjusted.

Tested with OTEL collector 0.74 and a relatively recent Jaeger.
@ybasket ybasket requested review from catostrophe and a team April 19, 2023 15:04
@calvinlfer
Copy link

@catostrophe @janstenpickle can you please have a look at this, I'm running into this issue and traces in the old format are no longer being accepted

Copy link
Contributor

@janstenpickle janstenpickle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@janstenpickle janstenpickle merged commit f552447 into master May 17, 2023
@janstenpickle janstenpickle deleted the fix/otel-format-changes branch May 17, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants