Send TraceProcess attributes on resource #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenTelemetry allows setting attributes on the resource associated with each span to attach information about the resource creating those spans, and the spec also details some conventions for naming [1]. So far, this integration has only been sending the `service.name` attribute as the only value in resource attributes, but for some tracing solutions, it's important to be able to specify other attributes, such as the deployment environment (`deployment.environment`). This moves the attributes associated with the `TraceProcess` from each individual span to the resource level, where they are more likely to belong. [1] https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/
|
Sorry I totally missed this, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenTelemetry allows setting attributes on the resource associated with each span to attach information about the resource creating those spans, and the spec also details some conventions for naming [1].
So far, this integration has only been sending the
service.nameattribute as the only value in resource attributes, but for some tracing solutions, it's important to be able to specify other attributes, such as the deployment environment (deployment.environment).This moves the attributes associated with the
TraceProcessfrom each individual span to the resource level, where they are more likely to belong.Unfortunately not backwards compatible, and makes life harder for those who need to add attributes to every span (although it should be possible with a custom span completer).
Disclaimer: I'm not to familiar with the
TraceProcessabstraction and realize that these changes might not be hitting the nail on the head, but I'd be happy to implement this in another way if you have other suggestions.[1] https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/